Config based versioning #344
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JakeGinnivan
force-pushed
the
ConfigBasedVersioning
branch
from
da75d3a to
e2f6a5b
Compare
| @@ -12,7 +12,8 @@ public void WhenDevelopBranchedFromMaster_MinorIsIncreased() | |||
| { | |||
| fixture.Repository.MakeATaggedCommit("1.0.0"); | |||
| fixture.Repository.CreateBranch("develop").Checkout(); | |||
| fixture.AssertFullSemver("1.1.0-unstable.0+0"); | |||
| fixture.Repository.MakeACommit(); | |||
| fixture.AssertFullSemver("1.1.0-unstable.1+0"); | |||
There was a problem hiding this comment.
develop is inconsistent. Other tags start counting at 1, develop at 0. Making the code generic means develop now starts counting it's tag at 1
JakeGinnivan
force-pushed
the
ConfigBasedVersioning
branch
from
e2f6a5b to
7311fd5
Compare
|
Once #343 is merged, this can be merged. I will continue development on a separate branch as it will involve changing tests and that would be good to be isolated in it's own PR |
…t kinda works but lots of small differences causing test breaks
JakeGinnivan
force-pushed
the
ConfigBasedVersioning
branch
from
7311fd5 to
513004a
Compare
|
Prob no point just reviewing this. Just look at #346 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Start of new internals which does not use any branch finders or know anything about branches.
Still a bunch of integration tests which need to be fixed when you switch over to use new stuff in
GitVersionFinder(uncomment commented line)