Fixes #387 #388
Merged
Fixes #387 #388
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -11,12 +11,12 @@ public class GitVersionContext | |||
| { | |||
| readonly Config configuration; | |||
|
|
|||
| public GitVersionContext(IRepository repository, Config configuration, bool isForTrackingBranchOnly = true) | |||
| : this(repository, repository.Head, configuration, isForTrackingBranchOnly) | |||
| public GitVersionContext(IRepository repository, Config configuration, bool isForTrackingBranchOnly = true, string commitId = null) | |||
There was a problem hiding this comment.
I think this should be on the config with the branch and such? Otherwise looks good
There was a problem hiding this comment.
To me, Config is something you read from the yaml file. This is not something you want to read from the yaml file (because it's too dynamic). I can easily move it to the config class though, just let me know what you prefer.
There was a problem hiding this comment.
I think you are right actually. Was thinking config included other arguments and such.
|
@SimonCropp is this something that should be on the Task? I can't see it being used but just wanted to check |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Works on both offline and online repositories. If commit id is not found, it will fall back to latest commit (current behavior). Also includes unit tests.