Showvariable paramter fix #447
Conversation
| @@ -12,7 +12,7 @@ public class ArgumentParser | |||
| { | |||
| static ArgumentParser() | |||
| { | |||
| var fields = typeof(VariableProvider).GetFields(BindingFlags.Public | BindingFlags.Static); | |||
| var fields = typeof(VersionVariables).GetProperties(); | |||
| VersionParts = fields.Select(x => x.Name.ToLower()).ToArray(); | |||
There was a problem hiding this comment.
Should actually be able to just do new VariableProvider().AvailableVariables now.
There was a problem hiding this comment.
I see an 'AvailableVariables' property contined in VersionVariables. To access that property I need to instantiate a new VersionVariables instance, either directly
new VersionVariables(...).AvailableVariables()
or through
VariableProvider.GetVariablesFor(...).AvailableVariables()
|
I see I failed the CI build. I'll take a better look at this tonight. |
|
|
|
One additional thing which would be good is to make a better error message when the variable doesn't exist. At the moment: I would like Do you think you could do that as part of this PR? Otherwise this looks good |
|
@KyleOndy any thoughts on extending this PR to list available variables before I merge? |
|
Let me clean up what I have and get some tests written. |
|
@KyleOndy how did you go? |
Working on #403. I am unfamiliar with reflection so I am not sure I am even on the right path here. I will look into writing some tests shortly.