Fixed path too long problem. #552
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In solutions containing a node_modules folder somewhere, there was a very good chance that you would get a PathTooLongException since the fully qualified name was larger than 260 chars. This change determines last write time in a way that doesn't throw this exception.
JakeGinnivan
added a commit
that referenced
this pull request
Aug 3, 2015
Fixed path too long problem.
|
Nice change, thanks! |
|
Thanks! :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In solutions containing a node_modules folder somewhere, there was a very good chance that you would get a PathTooLongException in DirectoryDateFinder.GetLastDirectoryWrite() since the fully qualified name in one of its sub directories would likely be larger than 260 chars. This change determines last write time in a way that doesn't throw this exception.
It was not possible to create a failing unit test without calling CreateDirectoryW in Windows API directly since .NET refuses to create directories with full path names longer than 260 characters.