Fix missing line breaks and typo in githubflow.md #556
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| 4) Push feature branch to [origin](../reference/git-setup.md#origin) | ||
| 5) Create pull request from origin/<featureBranch> -> upstream/master | ||
| 6) Review, fix raised comments, merge your PR or even better, get someone else to. | ||
| 1) Update master to latest [upstream](../reference/git-setup.md#upstream) code |
There was a problem hiding this comment.
This should actually be 1.
We could change to
1. Update master to latest [upstream](../reference/git-setup.md#upstream) code
1. Create a feature branch `git checkout -b myFeatureBranch`
If you use all 1's then it automatically incremented. Did you want to change this or I can merge and fix later because this is an improvement 👍
|
@thogil thanks |
SimonCropp
added a commit
that referenced
this pull request
Aug 19, 2015
Fix missing line breaks and typo in githubflow.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.