Skip to content

Add support for VSO agent #546 #560

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 4 commits into from

Conversation

clairernovotny
Copy link

No description provided.

@clairernovotny
Copy link
Author

This addresses #546 and #553 to add support for the VSO agent

@pascalberger
Copy link
Member

Awesome! Would be great if you could also update https://github.com/GitTools/GitVersion/blob/master/docs/more-info/build-server-setup/tfs-build-vnext.md with documentation how to setup GItVersion in TFS Build 2015 (and what restrictions currently apply)

@johnkattenhorn
Copy link
Contributor

Thanks @onovotny, I'll definitely try to check this out this week (Feet currently held to fire :-) ).

@clairernovotny
Copy link
Author

I'll add something to those docs -- it would also be nice to package this up as a VSO Build step, but the docs are still virtually non-existent.

https://github.com/Microsoft/tfs-cli/blob/master/docs/buildtasks.md

From what I can tell, the easiest way would be to create a package that includes the GitVersionTask.exe along with its containing json/packaging and push that to the vso gallery. Then it's just a matter of updating that when new versions are published.

@pascalberger
Copy link
Member

A build step would be nice. Unfortunately currently there's nothing like a VSO Gallery available. There exists the tfs-cli tool to upload custom build tasks to a VSO tenant.
Therefore I assume this repo (or a new one) would be the best place to host the build step releases at the moment.

Addint the GitVersion.exe in the build task should be easy to achieve. You can look at Sonar build task or the OctoTFS build task as samples. Maybe another possibility would be to set a demand in the task.json to check for GitVersion existance on the server, but this would require manual installation of GitVersion on the agent and setting some environment variables.

@clairernovotny
Copy link
Author

Agreed, but that should be a separate issue -- I'll file one for that. I think this can get merged in once I update the docs.

@clairernovotny
Copy link
Author

Closing this PR, #562 should be used instead as it contains everything needed to work with VSO.

@clairernovotny clairernovotny deleted the vso-agent branch September 1, 2015 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants