Skip to content

Updated Octopus Deploy docs #585

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 18, 2015
Merged

Updated Octopus Deploy docs #585

merged 1 commit into from
Aug 18, 2015

Conversation

sstorie
Copy link

@sstorie sstorie commented Aug 18, 2015

Added some specific git commands and clarified the process for creating Octopus Deploy packages that can be deployed.


Because Octopus uses NuGet under the covers you cannot publish every build into Octopus deploy. For this we have two possible options:
This limitation means you cannot continue to push revisions in this manner without some intervention (or changes to GitVersion's configuration). To work around this problem we have two possible options:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure that it is right to call this a limitation, I don't think that is the right word.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about combining the two like this?

Because Octopus uses NuGet under the covers you cannot continue to push revisions in this manner without some intervention (or changes to GitVersion's configuration). To work around this problem we have two possible options:

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@gep13
Copy link
Member

gep13 commented Aug 18, 2015

@sstorie aside from a few small comments, this looks good to me! Thank you very much for your contribution! 👍

@sstorie
Copy link
Author

sstorie commented Aug 18, 2015

Ok, let me incorporate your suggestions and update the PR.

@sstorie
Copy link
Author

sstorie commented Aug 18, 2015

Ok, I made the updates and the PR appears to have pulled them in. Tanks again for the feedback and let me know if you have any more.

@gep13
Copy link
Member

gep13 commented Aug 18, 2015

Looks good to me 👍

One final thing though...

Are you in a position to flatten these commits into a single commit? i.e. using git rebase

@sstorie
Copy link
Author

sstorie commented Aug 18, 2015

I can certainly try...let me see how I do that quick.

@gep13
Copy link
Member

gep13 commented Aug 18, 2015

This is how we tend to ask people to do it on one of the other projects I work on:

https://github.com/chocolatey/choco/blob/master/CONTRIBUTING.md#respond-to-feedback-on-pull-request

@sstorie
Copy link
Author

sstorie commented Aug 18, 2015

Ok, I'm really struggling with this, so I might just submit a new PR that has the single commit. I made the mistake of making an edit directly on GitHub and I think that's making this much harder for me than it would normally be.

@sstorie sstorie closed this Aug 18, 2015
…marks and an example scenario with the actual git commands.
@sstorie sstorie reopened this Aug 18, 2015
@sstorie
Copy link
Author

sstorie commented Aug 18, 2015

Ok, is this what you are looking for?

@gep13
Copy link
Member

gep13 commented Aug 18, 2015

Woot! 👍 Much better!

gep13 added a commit that referenced this pull request Aug 18, 2015
Updated Octopus Deploy docs
@gep13 gep13 merged commit 543a209 into GitTools:master Aug 18, 2015
@gep13
Copy link
Member

gep13 commented Aug 18, 2015

@sstorie thanks again for all your help on this!

@sstorie
Copy link
Author

sstorie commented Aug 18, 2015

No problem. Hopefully it helps the next person :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants