fix version cache key in msbuild task #594
Conversation
| var ticks = DirectoryDateFinder.GetLastDirectoryWrite(directory); | ||
| var key = string.Format("{0}:{1}:{2}", repo.Head.CanonicalName, repo.Head.Tip.Sha, ticks); | ||
| var ticks = DirectoryDateFinder.GetLastDirectoryWrite(gitDir); | ||
| var key = string.Format("{0}:{1}:{2}",gitDir, repo.Head.CanonicalName, repo.Head.Tip.Sha); |
There was a problem hiding this comment.
Ticks is no longer used?
There was a problem hiding this comment.
var key = string.Format("{0}:{1}:{2}:{3}",gitDir, repo.Head.CanonicalName, repo.Head.Tip.Sha, ticks); ?
There was a problem hiding this comment.
we dont want ticks in the key. they are used in the second step. a static dictionary is bascially a memory leak. keying on ticks is not great since we gradually add more to the dictionary on every change.
There was a problem hiding this comment.
Makes sense, if tip sha has changed, recalc. Got it
There was a problem hiding this comment.
The dictionary should probably be changed to a ConcurrentDictionary too, to avoid race conditions and concurrency issues if (and with Roslyn; when) the build is parallelized.
There was a problem hiding this comment.
@asbjornu agreed. make it so
fix version cache key in msbuild task
fixes #488