re #611 - Ensures branch with dynamic repositories and buildserver #612
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… buildserver When using a dynamic repository with a buildserver the current branch will for most buildserver types return null or empty, this causes no branch to be set, dynamic repositories require a branch. The fix ensures that if we are using dynamic repositories with a buildserver that if the buildserver does not return a branch we use the targetBranch specified via /b
|
With this we no longer need the |
Updates the BuildServerBase to provide a default implementation of GetCurrentBranch() that returns null, derived build servers can override if needed, this simplifies the resolution of the current branch name within ExecuteCore
|
Indeed, I can do a small tidy up of the current branch resolution with However this will mean that if using a dynamic repository with VSO the environment variable BUILD_SOURCEBRANCH will override the value of /b, but /b will still need to be specified as an argument. This may need to be addressed separately. |
JakeGinnivan
added a commit
that referenced
this pull request
Aug 26, 2015
re #611 - Ensures branch with dynamic repositories and buildserver
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using a dynamic repository with a buildserver the current branch will for most buildserver types return null or empty, this causes no branch to be set, dynamic repositories require a branch.
The fix ensures that if we are using dynamic repositories with a buildserver that if the buildserver does not return a branch we use the targetBranch specified via /b