Default config updates to recognize more defaults #622
Conversation
|
We need to do a config upgrade for all these. If someone has provided config overrides for these different branch configurations we can't have the new configs taking over |
| @@ -31,15 +31,15 @@ public static void ApplyDefaultsTo(Config config) | |||
| var configBranches = config.Branches.ToList(); | |||
|
|
|||
| ApplyBranchDefaults(config, GetOrCreateBranchDefaults(config, "master"), defaultTag: string.Empty, defaultPreventIncrement: true); | |||
| ApplyBranchDefaults(config, GetOrCreateBranchDefaults(config, "release[/-]"), defaultTag: "beta", defaultPreventIncrement: true); | |||
There was a problem hiding this comment.
Add another parameter to this which is migrate: and then it takes an array. You can then add migrate: new[] { "release[/-]" } and ApplyBranchDefaults should rename the configs to be migrated, then apply the defaults.
Just one idea on how to solve.
There was a problem hiding this comment.
I guess I'm not sure how the migration should work? Should apply branch defaults look for the old keys and rename them?
There was a problem hiding this comment.
Yeah exactly. So I have:
branches:
develop:
tag: beta
The effective config will have both develop and dev(elop)?.... We need to look for develop, rename it to the new one then delete it
|
Okay this should be working now. Also, the CanReadDocument test is now CanReadDocumentAndMigrate as that proves that it works. |
Default config updates to recognize more defaults
This addresses #620