Converted VSO Task to use PowerShell #717
Conversation
Added option to update specific assembly file
|
Thanks! This was already quickly discussed in #584. Using of a nodejs script is preferred over a PS script for x-plat compatibility. |
| "Major": "0", | ||
| "Minor": "0", | ||
| "Major": "3", | ||
| "Minor": "4", |
There was a problem hiding this comment.
You don't need to set the version number here. It'll be set at build time
There was a problem hiding this comment.
Sorry missed taking this out during testing, I'll fix this up.
|
Just to back up @pascalberger, in v4 we are pushing towards mono support for xplat so it would be better if we used nodejs. @johnkattenhorn would this be something you would be comfortable giving a shot? |
|
@johnkattenhorn bump, if not I can give it a crack once I have got through the issue triage and other PR's |
|
Hey @JakeGinnivan, sorry this has fallen completely off my radar, too be honest node.js isn't my strongest suite so if you're OK having a go then please be my guest. |
Is this still the plan? Seems like a lot of work to port what we already have to Node. Why not CoreCLR? |
|
@gep13 Node would only be for the build task (instead of the PowerShell script in this PR) not for the whole project. |
Ah! That makes a little more sense! 😄 |
Converted VSO Task to use PowerShell
|
I might update it as we get closer to v4, or even after |
Added option to update specific assembly file