Skip to content

A peeled target isn't necessarily a commit #722

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 1, 2015
Merged

A peeled target isn't necessarily a commit #722

merged 2 commits into from
Dec 1, 2015

Conversation

asbjornu
Copy link
Member

The peeled target isn't necessarily a Commit; it can be a Blob of any kind. This PR safe-casts it to Commit and only use it if it's not null. Should fix #721.

… kind. Safe-cast it to Commit and only use it if it's not null. Should fix #721.
@asbjornu
Copy link
Member Author

An idea on how to test for this would be appreciated. :)

@heaths
Copy link

heaths commented Nov 25, 2015

Looks good.

JakeGinnivan added a commit that referenced this pull request Dec 1, 2015
A peeled target isn't necessarily a commit
@JakeGinnivan JakeGinnivan merged commit fce5ad8 into GitTools:master Dec 1, 2015
@asbjornu asbjornu deleted the feature/peeled-target-blob branch February 2, 2016 07:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

InvalidCastException on untagged branch though tag on merged branch exists
3 participants