Feature/630 create assembly info #760
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… generated Adds argument /ensureassemblyinfo, when specified and /updateassemblyinfofilename is specified and does not exist we will generate a template of the assembly info file containing only *Version attributes in either cs, fs, vb allowing the version values to be replaced
… generated Adds argument /ensureassemblyinfo, when specified and /updateassemblyinfofilename is specified and does not exist we will generate a template of the assembly info file containing only *Version attributes in either cs, fs, vb allowing the version values to be replaced
… listed When specifying mulitple files the -ensureassemblyinfo switch can not be specified to protect against GitVersion generating multiple files with the same assembly attributes and breaking a build. -updateassemblyinfo Info.cs Info1.cs This will update any known version attributes in both files, if the file does not exist then it will be ignored -updateassemblyinfo Info.cs Info1.cs -ensureassemblyinfo This will cause a warning exception to be thrown as -ensureassemblyinfo can not be specified with multiple files -updateassemblyinfo ..\Common\Info.cs -ensureassemblyinfo Assuming ..\Common\Info.cs does not exist, this will generate an assembly info file at this location based on the embedded template for the file type (cs,vb,fs)
…itVersion into feature/630-create-assembly-info
…semblyinfo and /ensureassemblyinfo
|
@Philo looks like there are some issues with the CI Build as a result of the changes that you have made. Are you in a position to look into what is going on? Thanks! |
|
@gep13, I'll take a look, however may not be today |
|
@Philo not a problem at all 👍 |
… have been specified on the command line
|
@gep13 - fixed the build now |
|
@Philo thanks for your contribution here! 👍 |
|
I think this has a bug in it. It should only add the assembly info attributes in if the filename is specified. I think this is the cause of the assembly info issues since the last release |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Re #630