Support GitVersion.yml config file #575

[qetza]

No description provided.

[pascalberger]

The two last returns here are redundant. IMHO it would be clearer to return string.empty or null if none of both files exists, and add checks outside, instead of returning the path to the deprecated file which not even exists. Or otherwise I would suggest to at least return the path to the current file and not the deprecated one.

[qetza]

Hi Pascal,
The last two returns are not the same, the complete logic is:

• if the new file GitVersion.yml already exists we return it
• if the deprecated file GitVersionConfig.yaml already exists we warn and return it
• if no file exists we return the new file GitVersion.yml

[pascalberger]

Ah, sorry. missed the additional a in the last return 😊

[asbjornu]

@qetza How about renaming the variable yamlPath to deprecatedPath? Just a single letter separating two variables make them, as obvious by @pascalberger's comment, hard to differentiate. 😃

[asbjornu]

@qetza If you just rebase this onto the latest master to resolve the conflicts, I think this is a welcome addition that @gep13, @pascalberger or @JakeGinnivan can merge in when time allows. 👍

[JakeGinnivan]

Thanks @qetza! Been wanting this for ages :)