Implement support for AssemblyInfo.vb in the MSBuild GitVersionTask #811
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just some general notes about these changes.
VisualBasicAssemblyInfoBuilder
does not namespace itsGitVersionInformation
classNotInheritable
, provide aPrivate Sub New()
, and make all your membersShared
Lastly, I have this currently working in an existing VB.NET project at work - everything checks out with dotPeak, and it seems to be working as expected.