Skip to content

Added some better docs about how to use with Octopus deploy #813

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 29, 2016

Conversation

JakeGinnivan
Copy link
Contributor

Thoughts @gep13

I am actually using the second one with VSO and it works a treat.

The original instructions confused me :P

@gep13
Copy link
Member

gep13 commented Mar 29, 2016

@JakeGinnivan I thought the mkdocs.yml file had to live at the root of the repository? Is it allowed to be moved? Will the build still work?

Reading the rest of the actual content now :-) ...

@gep13
Copy link
Member

gep13 commented Mar 29, 2016

@JakeGinnivan these changes look good to me! 😄

@JakeGinnivan
Copy link
Contributor Author

@gep13 I thought I just read it could live in the docs folder. It's so annoying having it in the root, I just want to open the docs folder and be able to edit everything :)

@JakeGinnivan
Copy link
Contributor Author

Just confirmed it needs to be in the root :(

@JakeGinnivan
Copy link
Contributor Author

Fixed

@gep13
Copy link
Member

gep13 commented Mar 29, 2016

@JakeGinnivan said...
Just confirmed it needs to be in the root :(

Doh! That's a shame!

@@ -3,6 +3,9 @@
## Why is my version not incrementing?
GitVersion calculates the semantic version, this will only change once per *release*. Read more at [version increments](more-info/version-increments.md)

## I'm using Octopus deploy
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JakeGinnivan technically, this isn't a question 😄

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I know. shrug :P

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 just wanted to check you had thought about this, not swayed either way 😸

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wouldn't say I had thought a lot about it. Not sure how to phrase, just want to make the octopus deploy stuff more discoverable

@JakeGinnivan JakeGinnivan merged commit 2590764 into master Mar 29, 2016
@JakeGinnivan JakeGinnivan deleted the OctopusDeployDocs branch March 29, 2016 08:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants