Skip to content

Allow ignoring part of history when calculating version (issue #538) #851

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 13, 2016

Conversation

Tungsten78
Copy link

Based on @asbjornu 's recommendations for the yaml:

ignore:
    sha: [b6c0c9fda88830ebcd563e500a5a7da5a1658e98, 6c19c7c219ecf8dbc468042baefa73a1b213e8b1]
    commits-before: 2015-10-23T12:23:15

Sequence format follows YAML and can be alternatively formatted across lines:

ignore:
    sha: 
        - b6c0c9fda88830ebcd563e500a5a7da5a1658e98
        - 6c19c7c219ecf8dbc468042baefa73a1b213e8b1

Configuration will be translated to IVersionFilters of which there are 2:

  • MinDateVersionFilter
  • ShaVersionFilter

BaseVersionCalculator applies the version filtering and will exclude version candidates accordingly.

Log output is as follows:

2016-04-29 13:35:02       INFO [04/29/16 13:35:02:87] Merge message 'Merge pull request #176 in PROJ from hotfix/4.03/Tasks/some-task to support/4.1.0 : 4.3.0 with commit count source 5a8c7e368552e5808b20cabad28ea022df52735f
2016-04-29 13:35:02       INFO [04/29/16 13:35:02:87] Source was ignored due to commit having been excluded by configuration

Date Filter reason is: Source was ignored due to commit date being outside of configured range

Some possible future amendments:

  • Use the date filter to limit the history scrubbed by the strategies in an effort to improve overall performance.

@Tungsten78 Tungsten78 changed the title Allow ignoring part of history when calculating version #538 Allow ignoring part of history when calculating version (issue #538) Apr 29, 2016
@JakeGinnivan
Copy link
Contributor

This is awesome. Thanks!

@JakeGinnivan JakeGinnivan merged commit 6a28b87 into GitTools:master May 13, 2016
@tofutim
Copy link
Contributor

tofutim commented Jul 11, 2016

which version is this released on? I want to use this

@Tungsten78
Copy link
Author

@tofutim
Copy link
Contributor

tofutim commented Jul 11, 2016

thanks i just found it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants