AssemblyInfo update fixes #882
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Don't merge just yet. I discovered some bugs in a few of the tests. |
…ponding tests to test F# and VB as well.
asbjornu
force-pushed
the
feature/assembly-info-update-fixes
branch
from
0d5c2f2 to
1353214
Compare
…ionTask and GitVersionExe
…tuff into a VerifyAssemblyInfoFile method.
|
There we go. Merge whenever! 😄 |
| @@ -25,6 +25,6 @@ public void Json() | |||
|
|
|||
| var variables = VariableProvider.GetVariablesFor(semanticVersion, config, false); | |||
| var json = JsonOutputFormatter.ToJson(variables); | |||
| json.ShouldMatchApproved(); | |||
| json.ShouldMatchApproved(c => c.SubFolder("Approved")); | |||
There was a problem hiding this comment.
I am actually really happy with the ShouldMatchApproved api :P
There was a problem hiding this comment.
@JakeGinnivan It's beautiful! 😄
|
Sweet! |
Halling69
pushed a commit
to Halling69/GitVersion
that referenced
this pull request
Jun 8, 2016
…pdate-fixes AssemblyInfo update fixes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes the
AssemblyInfoFileUpdateclass support F# and Visual Basic as well as C# and with that fixes #858. It also adds a load of tests for F# and Visual Basic by making all of theAssemblyInfoFileUpdatetests into[TestCase]methods, and with that testing not just C#, but F# and VisualBasic as well.