Issue: #871 Fixing at least some occurences of error CS0579: Duplicate 'AssemblyVersion' attribute #897
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Duplicate 'AssemblyVersion' attribute when using shared assembly info by making regex tolerate whitespacing. Added unit test for whitespacing
| [TestCase("fs", "[<assembly: AssemblyVersion ( \"1.0.0.0\" )>]\r\n[<assembly: AssemblyInformationalVersion\t(\t\"1.0.0.0\"\t)>]\r\n[<assembly: AssemblyFileVersion\r\n(\r\n\"1.0.0.0\"\r\n)>]")] | ||
| [TestCase("vb", "<Assembly: AssemblyVersion ( \"1.0.0.0\" )>\r\n<Assembly: AssemblyInformationalVersion\t(\t\"1.0.0.0\"\t)>\r\n<Assembly: AssemblyFileVersion\r\n(\r\n\"1.0.0.0\"\r\n)>")] | ||
| [Category("NoMono")] | ||
| [Description("Won't run on Mono due to source information not being available for ShouldMatchApproved.")] |
There was a problem hiding this comment.
Since this test does not use ShouldMatchApproved(), you can remove the Category and Description attributes.
|
@Halling69 I have one comment it would be nice if you could fix. Otherwise, this looks good to me. |
|
I have removed the attributes from the test method I added. |
|
@Halling69 Awesome, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Made regex finding attributes in files tolerate whitespacing.
Added unit test for whitespacing: ShouldReplaceAssemblyVersionInRelativePathWithWhiteSpace
Fixes #871.