Skip to content

Updated IncrementStrategyFinder to support version bumping from tags #972

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

MikeEvansLarah
Copy link
Contributor

Updated IncrementStrategyFinder to support version bumping from tagged commits.

Updated tests and docs.
#971

[YamlMember(Alias = "no-bump-tag")]
public string NoBumpTag { get; set; }


Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove double linebreak

@pascalberger
Copy link
Member

Thanks for your contribution! LGTM

@asbjornu @gep13 @JakeGinnivan OK for you too merge this?

…mit also has an explicit semver message or tag.
@JakeGinnivan
Copy link
Contributor

Would you be able to walk me through a typical workflow on how you would use this feature @MikeLarah?

@JakeGinnivan
Copy link
Contributor

@MikeLarah am keen to hear more about the requirements for this change?

@MikeEvansLarah
Copy link
Contributor Author

@JakeGinnivan Sorry for the delayed response. Our intention was to use this in combination with a process in the CI build that determined whether the public API has been changed.
e.g. 1) developer commits and pushes up changes to a feature branch, 2) CI build does comparison between feature branch binaries and latest master binaries to determine if API has changed, 3) we tag the commit with relevant major/minor increment tag if necessary, 4) future builds are automatically version incremented using GitVersion (and will be correctly incremented when the feature is merged to develop branch)

@JakeGinnivan
Copy link
Contributor

Hey Mike,

I see a few issues with this approach

  1. More config :(
  2. git tag will have a heap of +semver-minor tags, which is noisy

Alternatives:

When you merge pull requests, you can alter the merge message in every tool I know. At that point simply append +semver: minor to the merge PR commit message.

Then you can use the new Mainline development mode in v4 to aggregate the versions from each merged PR. I think your process is working around the fact mainline was missing and I think it should be able to solve your problem. Let me know how you go, going to close this out for now (but we can keep the convo open)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants