Version calculation should not use tags from not merged branch #978
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tags from not merged branch
|
This test failed for version 3.4.1 (portable). And I would like to introduce this unit test to be sure that not facing the same problem in future. |
asbjornu
changed the title
|
@lerthe61 LGTM, thanks! 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Create unit test which cover scenario described in #862 issue. Short description:
Repositories consist from three branch - feature, develop and master. There is only fork (NO merge commits) in repository. Feature and Master branches grow up from the same commit. Tags in feature branch should not taking in count for version calculation for develop branch.