Skip to content

Cover ReleaseDate underlying changes with tests #98

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
May 8, 2014

Conversation

nulltoken
Copy link
Contributor

See #84

@nulltoken nulltoken self-assigned this Mar 7, 2014
@JakeGinnivan
Copy link
Contributor

Release date is moved into the SemVer class, so it gets approved with everything else, but it gets scrubbed out

But it should be easier to add these tests now

@nulltoken
Copy link
Contributor Author

  • Tests have been added.
  • This PR also adds a helper to reduce the boilerplate code required when dealing with equality implementation. If you don't feel that makes sense to keep it, I'd be happy to drop it.
  • Along the way, SemanticVersionPreReleaseTag was also fixed. It was lacking a GetHashCode() method.

andreasohlund added a commit that referenced this pull request May 8, 2014
Cover ReleaseDate underlying changes with tests
@andreasohlund andreasohlund merged commit 64c337e into master May 8, 2014
@andreasohlund andreasohlund deleted the ntk/releasedate_tests branch May 8, 2014 18:32
@nulltoken nulltoken removed their assignment Nov 10, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants