Skip to content

Mode and configuration documentation cleanup #989

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

asbjornu
Copy link
Member

@asbjornu asbjornu commented Aug 8, 2016

This PR should fix a dead link from configuration.md to versioning-mode.md, moves the latter file into the reference folder, consolidates its content with the different mode files and cleans up all related files in many various ways that I hope should improve this part of the documentation. I have no idea how this looks and works on ReadTheDocs, but fingers crossed this doesn't break anything!

@asbjornu asbjornu force-pushed the feature/mode-documentation-cleanup branch 2 times, most recently from c07178e to 7fe140d Compare August 9, 2016 11:33
@gep13
Copy link
Member

gep13 commented Aug 10, 2016

@asbjornu @JakeGinnivan is there a way to run readthedocs locally to test how it works before pushing?

@JakeGinnivan
Copy link
Contributor

Yeah, install mkdocs locally, then run mkdocs serve

@JakeGinnivan
Copy link
Contributor

@asbjornu asbjornu force-pushed the feature/mode-documentation-cleanup branch from 7fe140d to 16997a6 Compare August 10, 2016 08:16
@asbjornu
Copy link
Member Author

@JakeGinnivan Thanks for the tip. I clicked through the documentation locally and found a bug plus a better way to organize the versioning modes. I've also rebased the PR.

@gep13
Copy link
Member

gep13 commented Aug 10, 2016

@JakeGinnivan thanks! I have it up and running locally now as well (after a little fighting with python and pip)

@asbjornu asbjornu force-pushed the feature/mode-documentation-cleanup branch from ebf1fa6 to 9cf8c30 Compare August 10, 2016 09:59
@asbjornu
Copy link
Member Author

@JakeGinnivan I added a test in 9cf8c30 to ensure that all documentation files exist in the index. Through that, I found one that wasn't (git-branching-strategies/gitflow-examples_complete.md) and added that in 1e0ccfb.

@JakeGinnivan
Copy link
Contributor

@asbjornu that is awesome!

@JakeGinnivan JakeGinnivan merged commit 51b0543 into GitTools:master Aug 11, 2016
@asbjornu asbjornu deleted the feature/mode-documentation-cleanup branch August 11, 2016 06:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants