Skip to content

Display sidebar on no-TOC pages #2942

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 21 commits into from
Mar 13, 2025

Conversation

zenoachtig
Copy link
Contributor

@zenoachtig zenoachtig commented Mar 7, 2025

This PR changes the display behaviour of the left sidebar on pages that are configured to not show the table of contents.

This behaviour mirrors the right sidebar, which displays the mode toggle even if the page's outline option is set to hidden. When no-toc is enabled on a page, the table of contents is hidden from the sidebar. Any other elements, like the variant selector, logo, search bar and GitBook trademark, are still shown. On no-toc pages the sidebar shrinks in width to match the right sidebar, ensuring the same centred layout that no-toc pages currently feature.

On no-toc pages, the variant selector was previously shown in the header. Together with this change, the variant selector on no-toc pages now moves to the same secondary bar used for sections (if there are sections it is shown next to them, if there are no sections it is the only element in this bar). Together, these changes allow for better and more consistent landing pages.

Examples

Make

Screenshot 2025-03-11 at 17 41 32 Screenshot 2025-03-11 at 17 41 39

Nexthink

Screenshot 2025-03-11 at 17 41 58 Screenshot 2025-03-11 at 17 43 29

Pixelmator

Screenshot 2025-03-11 at 17 44 28 Screenshot 2025-03-11 at 17 44 33

Umbraco

Screenshot 2025-03-12 at 13 48 37 Screenshot 2025-03-12 at 13 48 47

Ordnance Survey

Screenshot 2025-03-11 at 17 48 21 Screenshot 2025-03-11 at 17 47 44

Awalkaday

Screenshot 2025-03-11 at 17 44 44 Screenshot 2025-03-11 at 17 44 51

Copy link

linear bot commented Mar 7, 2025

Copy link

changeset-bot bot commented Mar 7, 2025

🦋 Changeset detected

Latest commit: dfe72e8

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
gitbook Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented Mar 7, 2025

Copy link

argos-ci bot commented Mar 7, 2025

The latest updates on your projects. Learn more about Argos notifications ↗︎

Build Status Details Updated (UTC)
customers-v1 (Inspect) 👍 Changes approved 12 changed Mar 12, 2025, 2:39 PM
customers-v2 (Inspect) 👍 Changes approved 23 changed Mar 12, 2025, 2:41 PM
default (Inspect) 👍 Changes approved 15 changed Mar 12, 2025, 2:41 PM
v2-vercel (Inspect) 👍 Changes approved 2 changed Mar 12, 2025, 2:43 PM

@zenoachtig zenoachtig merged commit 16292de into main Mar 13, 2025
18 checks passed
@zenoachtig zenoachtig deleted the zeno/rnd-6419-add-trademark-to-landing-pages branch March 13, 2025 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants