-
Notifications
You must be signed in to change notification settings - Fork 4k
Display sidebar on no-TOC pages #2942
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
zenoachtig
merged 21 commits into
main
from
zeno/rnd-6419-add-trademark-to-landing-pages
Mar 13, 2025
Merged
Display sidebar on no-TOC pages #2942
zenoachtig
merged 21 commits into
main
from
zeno/rnd-6419-add-trademark-to-landing-pages
Mar 13, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: dfe72e8 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Summary of the deployments: Version 1 (production)
Version 2 (experimental)
Test content |
The latest updates on your projects. Learn more about Argos notifications ↗︎
|
emmerich
approved these changes
Mar 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the display behaviour of the left sidebar on pages that are configured to not show the table of contents.
This behaviour mirrors the right sidebar, which displays the mode toggle even if the page's
outline
option is set to hidden. Whenno-toc
is enabled on a page, the table of contents is hidden from the sidebar. Any other elements, like the variant selector, logo, search bar and GitBook trademark, are still shown. Onno-toc
pages the sidebar shrinks in width to match the right sidebar, ensuring the same centred layout thatno-toc
pages currently feature.On
no-toc
pages, the variant selector was previously shown in the header. Together with this change, the variant selector onno-toc
pages now moves to the same secondary bar used for sections (if there are sections it is shown next to them, if there are no sections it is the only element in this bar). Together, these changes allow for better and more consistent landing pages.Examples
Make
Nexthink
Pixelmator
Umbraco
Ordnance Survey
Awalkaday