Skip to content

Info hint background and link color fixes #2953

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Mar 11, 2025

Conversation

zenoachtig
Copy link
Contributor

@zenoachtig zenoachtig commented Mar 10, 2025

This PR fixes a few small issues with the hint block and links within hint blocks.

  • The info hint block did not properly use the set info semantic colour, now it does.
  • Links inside hint blocks should be coloured according to the semantic colour, with the exception of the info block, which uses the normal link colour. They now correctly follow this behaviour. (Fixes RND-6390)
  • Links using the accent link style had an underline that was too thin, it's now explicitly set to 1px.

Before & After

Screenshot 2025-03-10 at 13 44 35 Screenshot 2025-03-10 at 13 44 27

Copy link

changeset-bot bot commented Mar 10, 2025

🦋 Changeset detected

Latest commit: fe397c8

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
gitbook Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented Mar 10, 2025

Copy link

argos-ci bot commented Mar 10, 2025

The latest updates on your projects. Learn more about Argos notifications ↗︎

Build Status Details Updated (UTC)
customers-v1 (Inspect) 👍 Changes approved 12 changed Mar 11, 2025, 10:24 AM
customers-v2 (Inspect) 👍 Changes approved 15 changed Mar 11, 2025, 10:25 AM
default (Inspect) 👍 Changes approved 3 changed Mar 11, 2025, 10:26 AM
v2-vercel (Inspect) 👍 Changes approved 2 changed Mar 11, 2025, 10:28 AM

- Make underline proportional to font size
- Fix `info` hint background on strongly tinted backgrounds
@zenoachtig zenoachtig merged commit 9bc3d50 into main Mar 11, 2025
18 checks passed
@zenoachtig zenoachtig deleted the info-hint-background-and-link-color-fixes branch March 11, 2025 10:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants