Skip to content

Update target in shiki javascript engine #2968

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 11, 2025

Conversation

nolannbiron
Copy link
Member

No description provided.

Copy link

changeset-bot bot commented Mar 11, 2025

⚠️ No Changeset found

Latest commit: fd9a58d

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@nolannbiron nolannbiron changed the title Update target in shikin javascript engine Update target in shiki javascript engine Mar 11, 2025
@nolannbiron
Copy link
Member Author

@gregberge the results when using ES2024 are inconsistent. I ran the test more than 100 times with a script, and up to 5% of the runs failed (because shiki return console. instead of console).

However, when switching to ES2018 (as recommended for maximum compatibility in Shiki’s documentation), the tests run significantly faster (200ms instead of 700ms), and I can no longer reproduce the 5% failure.

@nolannbiron nolannbiron requested a review from gregberge March 11, 2025 13:10
Copy link

argos-ci bot commented Mar 11, 2025

The latest updates on your projects. Learn more about Argos notifications ↗︎

Build Status Details Updated (UTC)
customers-v1 (Inspect) ⚠️ Changes detected (Review) 8 changed Mar 11, 2025, 1:10 PM
customers-v2 (Inspect) ⚠️ Changes detected (Review) 9 changed Mar 11, 2025, 1:12 PM
default (Inspect) ⚠️ Changes detected (Review) 8 changed Mar 11, 2025, 1:13 PM
v2-vercel (Inspect) ⚠️ Changes detected (Review) 1 changed Mar 11, 2025, 1:15 PM

@nolannbiron nolannbiron merged commit e996904 into main Mar 11, 2025
13 of 18 checks passed
@nolannbiron nolannbiron deleted the nolann/fix-highlight-tests branch March 11, 2025 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants