Fix OGImage icon fetch on cloudflare

[conico974]

When a request for OG Image arrives for a custom domain, the requested favicon is requested from the same domain (i.e. https://thedomain.com/~gitbook/icon)
In Cloudflare, we were using a service binding, but by doing so, this bypass setting the x-gitbook-url header and thus the request will end up not being able to match getSiteUrlFromRequest

gitbook/packages/gitbook-v2/src/middleware.ts

Lines 382 to 391 in ba0094a

	/**
	* The URL of the GitBook content can be passed in 3 different ways (in order of priority):
	* - The request has a `X-GitBook-URL` header:
	* URL is taken from the header.
	* - The request has a `X-Forwarded-Host` header:
	* Host is taken from the header, pathname is taken from the request URL.
	* - The request URL is matching `/url/:url`:
	* URL is taken from the pathname.
	*/
	function getSiteURLFromRequest(request: NextRequest): URLWithMode | null {

We should be fine without the service binding since we set global_fetch_strictly_public compatibility flag

The icon will return a 404 and the OG Image Generation will fail with a 500

Should fix RND-7140

[linear]

RND-7140 Some OGImage fails on cloudflare

[changeset-bot]

⚠️ No Changeset found

Latest commit: 863c196

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

[github-actions]

Summary of the deployments:

Version 1

Version	URL	Status
Latest commit	https://72acf91b.gitbook-open.pages.dev	✅
PR	https://pr3253.gitbook-open.pages.dev	✅

Version 2

Version	URL	Status
Vercel	https://gitbook-v2-gui7nh9fy-gitbook.vercel.app	✅
Cloudflare	https://622942e5-gitbook-open-v2-preview.gitbook.workers.dev	✅

Test content

Site	v1	2v	2c
GitBook	https://72acf91b.gitbook-open.pages.dev/gitbook.com/docs	https://gitbook-v2-gui7nh9fy-gitbook.vercel.app/url/gitbook.com/docs	https://622942e5-gitbook-open-v2-preview.gitbook.workers.dev/url/gitbook.com/docs
E2E	https://72acf91b.gitbook-open.pages.dev/gitbook.gitbook.io/test-gitbook-open	https://gitbook-v2-gui7nh9fy-gitbook.vercel.app/url/gitbook.gitbook.io/test-gitbook-open	https://622942e5-gitbook-open-v2-preview.gitbook.workers.dev/url/gitbook.gitbook.io/test-gitbook-open

[argos-ci]

The latest updates on your projects. Learn more about Argos notifications ↗︎

Build	Status	Details	Updated (UTC)
customers-v1 (Inspect)	✅ No changes detected	-	May 21, 2025, 1:01 PM
customers-v2 (Inspect)	👍 Changes approved	80 changed	May 21, 2025, 1:18 PM
default (Inspect)	✅ No changes detected	-	May 21, 2025, 1:05 PM
v2-cloudflare (Inspect)	✅ No changes detected	-	May 21, 2025, 1:07 PM
v2-vercel (Inspect)	✅ No changes detected	-	May 21, 2025, 1:07 PM

[SamyPesse]

Makes sense, the alternative was to set the header as well here, but I think it's better to unify between Vercel and Cloudflare on the way we fetch things here

[conico974]

Makes sense, the alternative was to set the header as well here, but I think it's better to unify between Vercel and Cloudflare on the way we fetch things here

I've started doing exactly that at first, but there is not much benefits in doing so (technically it's slightly faster), it just complicate things.