-
Notifications
You must be signed in to change notification settings - Fork 4k
Move DO to a 3rd worker #3270
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Move DO to a 3rd worker #3270
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -64,6 +64,16 @@ runs: | |
| GITBOOK_RUNTIME: cloudflare | ||
| shell: bash | ||
|
|
||
| - name: Upload the DO worker | ||
| uses: cloudflare/[email protected] | ||
| with: | ||
| apiToken: ${{ inputs.apiToken }} | ||
| accountId: ${{ inputs.accountId }} | ||
| workingDirectory: ./ | ||
| wranglerVersion: '4.10.0' | ||
| environment: ${{ inputs.environment }} | ||
| command: deploy --config ./packages/gitbook-v2/openNext/customWorkers/doWrangler.jsonc | ||
|
|
||
| - id: upload_server | ||
| name: Upload server to Cloudflare | ||
| uses: cloudflare/[email protected] | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,38 @@ | ||
| // This worker only purposes it to host the different DO that we will need in the other workers. | ||
| import { DurableObject } from 'cloudflare:workers'; | ||
|
|
||
| // `use cache` could cause multiple writes to the same key to happen concurrently, there is a limit of 1 write per key/second | ||
| // so we need to buffer writes to the R2 bucket to avoid hitting this limit. | ||
| export class R2WriteBuffer extends DurableObject { | ||
| writePromise; | ||
|
|
||
| async write(cacheKey, value) { | ||
| // We are already writing to this key | ||
| if (this.writePromise) { | ||
| return; | ||
| } | ||
|
|
||
| this.writePromise = this.env.NEXT_INC_CACHE_R2_BUCKET.put(cacheKey, value); | ||
| this.ctx.waitUntil( | ||
| this.writePromise.finally(() => { | ||
| this.writePromise = undefined; | ||
| }) | ||
| ); | ||
| } | ||
| } | ||
|
|
||
| export { DOQueueHandler } from '../../.open-next/.build/durable-objects/queue.js'; | ||
|
|
||
| export { DOShardedTagCache } from '../../.open-next/.build/durable-objects/sharded-tag-cache.js'; | ||
|
|
||
| export default { | ||
| async fetch() { | ||
| // This worker does not handle any requests, it only provides Durable Objects | ||
| return new Response('This worker is not meant to handle requests directly', { | ||
| status: 400, | ||
| headers: { | ||
| 'Content-Type': 'text/plain', | ||
| }, | ||
| }); | ||
| }, | ||
| }; | ||
127 changes: 127 additions & 0 deletions
127
packages/gitbook-v2/openNext/customWorkers/doWrangler.jsonc
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,127 @@ | ||
| { | ||
| "main": "do.js", | ||
| "name": "gitbook-open-v2-do", | ||
| "compatibility_date": "2025-04-14", | ||
| "compatibility_flags": [ | ||
| "nodejs_compat", | ||
| "allow_importable_env", | ||
| "global_fetch_strictly_public" | ||
| ], | ||
| "observability": { | ||
| "enabled": true | ||
| }, | ||
| "env": { | ||
| "preview": { | ||
| "vars": { | ||
| "STAGE": "preview", | ||
| "NEXT_CACHE_DO_QUEUE_DISABLE_SQLITE": "true" | ||
| }, | ||
| "r2_buckets": [ | ||
| { | ||
| "binding": "NEXT_INC_CACHE_R2_BUCKET", | ||
| "bucket_name": "gitbook-open-v2-cache-preview" | ||
| } | ||
| ], | ||
| "durable_objects": { | ||
| "bindings": [ | ||
| { | ||
| "name": "NEXT_CACHE_DO_QUEUE", | ||
| "class_name": "DOQueueHandler" | ||
| }, | ||
| { | ||
| "name": "NEXT_TAG_CACHE_DO_SHARDED", | ||
| "class_name": "DOShardedTagCache" | ||
| }, | ||
| { | ||
| "name": "WRITE_BUFFER", | ||
| "class_name": "R2WriteBuffer" | ||
| } | ||
| ] | ||
| }, | ||
| "migrations": [ | ||
| { | ||
| "tag": "v1", | ||
| "new_sqlite_classes": ["DOQueueHandler", "DOShardedTagCache", "R2WriteBuffer"] | ||
| } | ||
| ] | ||
| }, | ||
| "staging": { | ||
| "vars": { | ||
| "STAGE": "staging", | ||
| "NEXT_CACHE_DO_QUEUE_DISABLE_SQLITE": "true" | ||
| }, | ||
| "r2_buckets": [ | ||
| { | ||
| "binding": "NEXT_INC_CACHE_R2_BUCKET", | ||
| "bucket_name": "gitbook-open-v2-cache-staging" | ||
| } | ||
| ], | ||
| "tail_consumers": [ | ||
| { | ||
| "service": "gitbook-x-staging-tail" | ||
| } | ||
| ], | ||
| "durable_objects": { | ||
| "bindings": [ | ||
| { | ||
| "name": "NEXT_CACHE_DO_QUEUE", | ||
| "class_name": "DOQueueHandler" | ||
| }, | ||
| { | ||
| "name": "NEXT_TAG_CACHE_DO_SHARDED", | ||
| "class_name": "DOShardedTagCache" | ||
| }, | ||
| { | ||
| "name": "WRITE_BUFFER", | ||
| "class_name": "R2WriteBuffer" | ||
| } | ||
| ] | ||
| }, | ||
| "migrations": [ | ||
| { | ||
| "tag": "v1", | ||
| "new_sqlite_classes": ["DOQueueHandler", "DOShardedTagCache", "R2WriteBuffer"] | ||
| } | ||
| ] | ||
| }, | ||
| "production": { | ||
| "vars": { | ||
| "NEXT_CACHE_DO_QUEUE_DISABLE_SQLITE": "true", | ||
| "STAGE": "production" | ||
| }, | ||
| "r2_buckets": [ | ||
| { | ||
| "binding": "NEXT_INC_CACHE_R2_BUCKET", | ||
| "bucket_name": "gitbook-open-v2-cache-production" | ||
| } | ||
| ], | ||
| "tail_consumers": [ | ||
| { | ||
| "service": "gitbook-x-prod-tail" | ||
| } | ||
| ], | ||
| "durable_objects": { | ||
| "bindings": [ | ||
| { | ||
| "name": "NEXT_CACHE_DO_QUEUE", | ||
| "class_name": "DOQueueHandler" | ||
| }, | ||
| { | ||
| "name": "NEXT_TAG_CACHE_DO_SHARDED", | ||
| "class_name": "DOShardedTagCache" | ||
| }, | ||
| { | ||
| "name": "WRITE_BUFFER", | ||
| "class_name": "R2WriteBuffer" | ||
| } | ||
| ] | ||
| }, | ||
| "migrations": [ | ||
| { | ||
| "tag": "v1", | ||
| "new_sqlite_classes": ["DOQueueHandler", "DOShardedTagCache", "R2WriteBuffer"] | ||
| } | ||
| ] | ||
| } | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.