fix!: remove regex feature in favor of revparse-regex.

`revparse-regex` is only used when parsing revspecs that use a special syntax.
This feature is also enabled by default.

Author: Byron

gix/Cargo.toml

@@ -58,7 +58,7 @@ default = ["max-performance-safe", "comfort", "extras"]
 #! Bundles are for convenience only and bear no further meaning beyond the cargo manifest file.
 
 ## Various additional features and capabilities that are not necessarily part of what most users would need.
-extras = ["worktree-stream", "worktree-archive", "blob-diff", "revision"]
+extras = ["worktree-stream", "worktree-archive", "blob-diff", "revision", "revparse-regex"]
 
 ## Various progress-related features that improve the look of progress message units.
 comfort = ["gix-features/progress-unit-bytes", "gix-features/progress-unit-human-numbers"]
@@ -71,6 +71,10 @@ comfort = ["gix-features/progress-unit-bytes", "gix-features/progress-unit-human
 ## Make revspec parsing possible, as well describing revision.
 revision = ["gix-revision/describe"]
 
+## If enabled, revspecs now support the regex syntax like `@^{/^.*x}`. Otherwise, only substring search is supported.
+## This feature does increase compile time for niche-benefit, but is required for fully git-compatible revspec parsing.
+revparse-regex = ["regex", "revision"]
+
 ## Make it possible to diff blobs line by line. Note that this feature is integral for implementing tree-diffs as well due to the handling of rename-tracking,
 ## which relies on line-by-line diffs in some cases.
 blob-diff = ["gix-diff/blob"]

gix/src/revision/spec/parse/delegate/navigate.rs

@@ -157,9 +157,9 @@ impl<'repo> delegate::Navigate for Delegate<'repo> {
         self.unset_disambiguate_call();
         self.follow_refs_to_objects_if_needed()?;
 
-        #[cfg(not(feature = "regex"))]
+        #[cfg(not(feature = "revparse-regex"))]
         let matches = |message: &BStr| -> bool { message.contains_str(regex) ^ negated };
-        #[cfg(feature = "regex")]
+        #[cfg(feature = "revparse-regex")]
         let matches = match regex::bytes::Regex::new(regex.to_str_lossy().as_ref()) {
             Ok(compiled) => {
                 let needs_regex = regex::escape(compiled.as_str()) != regex;

gix/src/revision/spec/parse/types.rs

@@ -100,15 +100,15 @@ pub enum Error {
     RevWalkIterInit(#[from] crate::reference::iter::init::Error),
     #[error(transparent)]
     RevWalkAllReferences(#[from] gix_ref::packed::buffer::open::Error),
-    #[cfg(feature = "regex")]
+    #[cfg(feature = "revparse-regex")]
     #[error(transparent)]
     InvalidRegex(#[from] regex::Error),
     #[cfg_attr(
-        feature = "regex",
+        feature = "revparse-regex",
         error("None of {commits_searched} commits from {oid} matched regex {regex:?}")
     )]
     #[cfg_attr(
-        not(feature = "regex"),
+        not(feature = "revparse-regex"),
         error("None of {commits_searched} commits from {oid} matched text {regex:?}")
     )]
     NoRegexMatch {
@@ -117,11 +117,11 @@ pub enum Error {
         commits_searched: usize,
     },
     #[cfg_attr(
-        feature = "regex",
+        feature = "revparse-regex",
         error("None of {commits_searched} commits reached from all references matched regex {regex:?}")
     )]
     #[cfg_attr(
-        not(feature = "regex"),
+        not(feature = "revparse-regex"),
         error("None of {commits_searched} commits reached from all references matched text {regex:?}")
     )]
     NoRegexMatchAllRefs { regex: BString, commits_searched: usize },

gix/tests/gix.rs

@@ -1,30 +1,30 @@
-#[cfg(not(feature = "regex"))]
+#[cfg(not(feature = "revparse-regex"))]
 mod util;
-#[cfg(not(feature = "regex"))]
+#[cfg(not(feature = "revparse-regex"))]
 use util::*;
 
-#[cfg(not(feature = "regex"))]
+#[cfg(not(feature = "revparse-regex"))]
 mod clone;
-#[cfg(not(feature = "regex"))]
+#[cfg(not(feature = "revparse-regex"))]
 mod commit;
-#[cfg(not(feature = "regex"))]
+#[cfg(not(feature = "revparse-regex"))]
 mod config;
-#[cfg(not(feature = "regex"))]
+#[cfg(not(feature = "revparse-regex"))]
 mod head;
-#[cfg(not(feature = "regex"))]
+#[cfg(not(feature = "revparse-regex"))]
 mod id;
-#[cfg(not(feature = "regex"))]
+#[cfg(not(feature = "revparse-regex"))]
 mod init;
-#[cfg(not(feature = "regex"))]
+#[cfg(not(feature = "revparse-regex"))]
 mod object;
-#[cfg(not(feature = "regex"))]
+#[cfg(not(feature = "revparse-regex"))]
 mod reference;
-#[cfg(not(feature = "regex"))]
+#[cfg(not(feature = "revparse-regex"))]
 mod remote;
-#[cfg(not(feature = "regex"))]
+#[cfg(not(feature = "revparse-regex"))]
 mod repository;
-#[cfg(not(feature = "regex"))]
+#[cfg(not(feature = "revparse-regex"))]
 #[cfg(feature = "revision")]
 mod revision;
-#[cfg(not(feature = "regex"))]
+#[cfg(not(feature = "revparse-regex"))]
 mod submodule;

gix/tests/revision/spec/from_bytes/regex.rs

@@ -12,7 +12,7 @@ mod with_known_revision {
     use crate::revision::spec::from_bytes::parse_spec;
 
     #[test]
-    #[cfg(not(feature = "regex"))]
+    #[cfg(not(feature = "revparse-regex"))]
     fn contained_string_matches_in_unanchored_regex_and_disambiguates_automatically() {
         let repo = repo("ambiguous_blob_tree_commit").unwrap();
         let expected = Spec::from_id(hex_to_id("0000000000e4f9fbd19cf1e932319e5ad0d1d00b").attach(&repo));
@@ -28,7 +28,7 @@ mod with_known_revision {
     }
 
     #[test]
-    #[cfg(feature = "regex")]
+    #[cfg(feature = "revparse-regex")]
     fn contained_string_matches_in_unanchored_regex_and_disambiguates_automatically() {
         let repo = repo("ambiguous_blob_tree_commit").unwrap();
         let expected = Spec::from_id(hex_to_id("0000000000e4f9fbd19cf1e932319e5ad0d1d00b").attach(&repo));
@@ -63,7 +63,7 @@ mod find_youngest_matching_commit {
     use crate::revision::spec::from_bytes::parse_spec;
 
     #[test]
-    #[cfg(not(feature = "regex"))]
+    #[cfg(not(feature = "revparse-regex"))]
     fn contained_string_matches() {
         let repo = repo("complex_graph").unwrap();
 
@@ -91,7 +91,7 @@ mod find_youngest_matching_commit {
     }
 
     #[test]
-    #[cfg(feature = "regex")]
+    #[cfg(feature = "revparse-regex")]
     fn regex_matches() {
         let repo = repo("complex_graph").unwrap();
 

justfile

@@ -116,6 +116,7 @@ check:
     cargo check -p gix --no-default-features --features progress-tree
     cargo check -p gix --no-default-features --features blob-diff
     cargo check -p gix --no-default-features --features revision
+    cargo check -p gix --no-default-features --features revparse-regex
     cargo check -p gix --no-default-features
     cargo check -p gix-odb --features serde
     cargo check --no-default-features --features max-control
@@ -158,7 +159,6 @@ unit-tests:
     cargo test -p gix --no-default-features
     cargo test -p gix --features async-network-client
     cargo test -p gix --features blocking-network-client
-    cargo test -p gix --features regex
     cargo test -p gitoxide-core --lib
 
 # These tests aren't run by default as they are flaky (even locally)