Skip to content

test size_of_sha1 reports wrong size on i386 #1134

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

alexanderkjall
Copy link
Contributor

Build failure:

159s 
159s running 1 test
159s test size_of_sha1 ... FAILED
159s 
159s failures:
159s 
159s ---- size_of_sha1 stdout ----
159s thread 'size_of_sha1' panicked at 'assertion failed: `(left == right)`
159s   left: `96`,
159s  right: `104`', tests/hash.rs:12:5
159s stack backtrace:
159s    0: rust_begin_unwind
159s              at /usr/src/rustc-1.70.0/library/std/src/panicking.rs:578:5
159s    1: core::panicking::panic_fmt
159s              at /usr/src/rustc-1.70.0/library/core/src/panicking.rs:67:14
159s    2: core::panicking::assert_failed_inner
159s    3: core::panicking::assert_failed
159s              at /usr/src/rustc-1.70.0/library/core/src/panicking.rs:228:5
159s    4: hash::size_of_sha1
159s              at ./tests/hash.rs:12:5
159s    5: hash::size_of_sha1::{{closure}}
159s              at ./tests/hash.rs:11:19
159s    6: core::ops::function::FnOnce::call_once
159s              at /usr/src/rustc-1.70.0/library/core/src/ops/function.rs:250:5
159s    7: core::ops::function::FnOnce::call_once
159s              at /usr/src/rustc-1.70.0/library/core/src/ops/function.rs:250:5
159s note: Some details are omitted, run with `RUST_BACKTRACE=full` for a verbose backtrace.
159s 
159s 
159s failures:
159s     size_of_sha1

From: https://ci.debian.net/data/autopkgtest/testing/i386/r/rust-gix-features/40167696/log.gz

Can be reproduced with cargo test --all-features

I'm far from certain that this is the correct fix, as this more documents the size differences on the different architectures.

Copy link
Member

@Byron Byron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot!

It's strange that you were able to find this failure as I'd expect this to be tested by the 32bit CI job.

Probably I am missing something, somewhere.

@Byron
Copy link
Member

Byron commented Nov 27, 2023

Thanks a lot for your help!

@Byron Byron merged commit a12682d into GitoxideLabs:main Nov 27, 2023
@alexanderkjall alexanderkjall deleted the gix-features-i386-test-failure branch November 28, 2023 05:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants