Skip to content

fix: use correct fields for ctime and mtime on AIX #1194

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 20, 2023

Conversation

ecnelises
Copy link
Contributor

On AIX, ctime and mtime are structs containing seconds and nanoseconds.

Reference: https://github.com/rust-lang/libc/blob/f05d6a35b25288b143241ebb6b4b071618945431/src/unix/aix/powerpc64.rs#L63

On AIX, ctime and mtime are structs containing seconds and nanoseconds.
@Byron
Copy link
Member

Byron commented Dec 20, 2023

Thanks a lot!

When looking at these seemingly arbitrarily renamed field names over three operating systems, I feel like they are a cruel joke introduced for the sake of incompatibility 😅.

@Byron Byron merged commit 940e3ca into GitoxideLabs:main Dec 20, 2023
@ecnelises
Copy link
Contributor Author

Thanks. Maybe we can reuse code from rustix or std? I remember there's similar code.

@Byron
Copy link
Member

Byron commented Dec 21, 2023

It would certainly be wonderful to be able to 'inherit' all the compatibility layers they must have put in already. Right now each time there is a change here, there is also a risk to break another platform, of which none is currently tested in CI.

Maybe that could be an additional approach - know the platforms to support and try to build gix on them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants