Skip to content

Use the stable Rust toolchain to build all targets #1513

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 12, 2024

Conversation

EliahKagan
Copy link
Member

@EliahKagan EliahKagan commented Aug 12, 2024

This uses stable rather than nightly Rust toolchains to build all binaries for GitHub releases in the release.yml workflow, as discussed in #1497. Prior to this, some of them already used stable toolchains, while others used nightly toolchains. No targets are changed here, only toolchains (and not the target triple part).

Here is workflow run with modified workflow, and here's an examination of generated artifacts from it.

Copy link
Member

@Byron Byron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, that looks like a great improvement!

@Byron Byron merged commit ea373e6 into GitoxideLabs:main Aug 12, 2024
19 checks passed
@EliahKagan EliahKagan deleted the releasing-stable branch August 12, 2024 07:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants