git-glob windows support #383
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is done by renaming it to `wildcard::MODE::NO_MATCH_SLASH_LITERAL` and actually fits what it does.
also: prepare for OS specific tests, even though right now there should be none.
As also indicated by the git source, there is no special handling of backslashes on windows.
Byron
force-pushed
the
glob-windows-support
branch
from
b9be8c1 to
16570ef
Compare
Byron
added a commit
that referenced
this pull request
Apr 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On windows patterns seem to handle backslashes differently. Figure out where that happens and make sure we can reproduce it.
Bring in OS-specific tests as well which are still disabled in the baseline test.
Tasks
add OS specific tests togit-glob