-
-
Notifications
You must be signed in to change notification settings - Fork 358
Config updates #44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Config updates #44
Conversation
…next up is bringing in the correct output types.
…as some of the new features are very much what's needed here.
If this is 'just looking' then I feel the thorough version of this will be a complete implementation - I wouldn't mind that at all ;). Especially the
My guess is that using I won't take my eyes of this PR and have it replace my branch as soon as you give the go! Thanks again, your work is invaluable! |
I have to close this PR as it was superseded by a contributed implementation which is now available in Thanks a million for your help here ❤️, and even though I am glad to have a |
@Byron
I'm just starting to have a look now.
dangerous::Span
is now used instead. This actually is less error prone because ranges could be taken from the wrong offset.dangerous::Span
internally holds pointer references to solve this!PartialOrd/Ord
derives as I'm not sure what is semantic in the order, maybe you can help me here.dangerous::Span
doesn't implement it because it doesn't make too much sense to me, which prevents derives. On a quick search, neither doesRange
Range and friends don't implement Ord/PartialOrd rust-lang/rust#75607I'll be looking a little more though this soon I promise!
On another note, I'm thinking of making a recommendation of only using
dangerous::input()
for the top level and not within sub parsers. I'll be explaining my reasoning soon :)