feat: ✨ Added mod disabling #241
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KANAjetzt
reviewed
May 3, 2023
|
Ready to merge if you did a run test 👍 |
|
Ok, did a test run in Brotato with no errors, so it looks good to merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements mod disabling at runtime, we expose
disable_modsanddisable_modin the ModLoaderMod class that can be called by any mod, but it has to be noted that those methods should only be called when needed as they can cause the game to break if a specific mod has not implemented their_disablemethod in the mod_main.gd script of their mod correctly.We also expose
remove_all_extensions_of_modin the _ModLoaderScriptExtension class that should be still handled with care by the mod developers and can be used to disable all the extensions of their mod for specific situations.Finally there we expose
get_mod_data_from_namespacein the ModData class that enables us to retrieve the ModData of a mod from the provided mod_id.#240 is required before merging this one