Skip to content

fix: 🐛 log stack only saved for logged_messages.all #278

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 17, 2023
Merged

fix: 🐛 log stack only saved for logged_messages.all #278

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions addons/mod_loader/api/log.gd
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -249,13 +249,15 @@ static func _get_verbosity() -> int:


static func _store_log(log_entry: ModLoaderLogEntry) -> void:
var existing_entry: ModLoaderLogEntry

# Store in all
# If it's a new entry
if not ModLoaderStore.logged_messages.all.has(log_entry.get_md5()):
ModLoaderStore.logged_messages.all[log_entry.get_md5()] = log_entry
# If it's a existing entry
else:
var existing_entry: ModLoaderLogEntry = ModLoaderStore.logged_messages.all[log_entry.get_md5()]
existing_entry = ModLoaderStore.logged_messages.all[log_entry.get_md5()]
existing_entry.time = log_entry.time
existing_entry.stack.push_back(log_entry)

Expand All @@ -264,10 +266,10 @@ static func _store_log(log_entry: ModLoaderLogEntry) -> void:
if not ModLoaderStore.logged_messages.by_mod.has(log_entry.mod_name):
ModLoaderStore.logged_messages.by_mod[log_entry.mod_name] = {}

ModLoaderStore.logged_messages.by_mod[log_entry.mod_name][log_entry.get_md5()] = log_entry
ModLoaderStore.logged_messages.by_mod[log_entry.mod_name][log_entry.get_md5()] = log_entry if not existing_entry else existing_entry

# Store in by_type
ModLoaderStore.logged_messages.by_type[log_entry.type.to_lower()][log_entry.get_md5()] = log_entry
ModLoaderStore.logged_messages.by_type[log_entry.type.to_lower()][log_entry.get_md5()] = log_entry if not existing_entry else existing_entry


static func _is_logged_before(entry: ModLoaderLogEntry) -> bool:
Expand Down