Skip to content

Fix manifest keys const name error in PR #27 #29

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Jan 15, 2023
Merged

Fix manifest keys const name error in PR #27 #29

Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
e2b3766
docs: update example manifest.json
ithinkandicode Jan 15, 2023
68f441a
update manifest key validation to match Thunderstore requirements
ithinkandicode Jan 15, 2023
0b4dd63
docs: generic manifest.json
ithinkandicode Jan 15, 2023
7581ae7
Merge branch 'main' into manifest-json-thunderstore
ithinkandicode Jan 15, 2023
c67f207
Merge branch 'GodotModding:main' into manifest-json-thunderstore
ithinkandicode Jan 15, 2023
c311da6
fix manifest keys const not being renamed in a previous commit
ithinkandicode Jan 15, 2023
3352e78
Merge branch 'manifest-json-thunderstore' of https://github.com/ithin…
ithinkandicode Jan 15, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions loader/mod_loader.gd
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,8 +49,7 @@ const UNPACKED_DIR = "res://mods-unpacked/"
const REQUIRED_MOD_FILES = ["mod_main.gd", "manifest.json"]

# Required keys in a mod's manifest.json file
const REQUIRED_META_TAGS = [
"id",
const REQUIRED_MANIFEST_KEYS_ROOT = [
"name",
"version_number",
"website_url",
Expand Down