Skip to content

fix: 🐛 added missing static #291

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 21, 2023
Merged

fix: 🐛 added missing static #291

merged 1 commit into from
Jun 21, 2023

Conversation

KANAjetzt
Copy link
Member

added the missing static to the methods in ModLoaderModManager

closes #289

@KANAjetzt
fix: 🐛 added missing static
dcbddc7 
added the missing `static` to the methods in `ModLoaderModManager`

closes GodotModding#289
@KANAjetzt KANAjetzt added the bug Something isn't working label Jun 21, 2023
@KANAjetzt KANAjetzt added this to the v6.0.1 milestone Jun 21, 2023
@KANAjetzt KANAjetzt requested review from ithinkandicode, Qubus0, otDan and a team June 21, 2023 06:47
@KANAjetzt KANAjetzt self-assigned this Jun 21, 2023
Qubus0
Qubus0 approved these changes Jun 21, 2023
View reviewed changes
Copy link
Collaborator

@Qubus0 Qubus0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

... this might be breaking.

@KANAjetzt KANAjetzt added the breaking Breaking change label Jun 21, 2023
@KANAjetzt KANAjetzt added this pull request to the merge queue Jun 21, 2023
Merged via the queue into GodotModding:development with commit 0434f74 Jun 21, 2023
@KANAjetzt KANAjetzt mentioned this pull request Jun 21, 2023
Closed
@KANAjetzt KANAjetzt deleted the fix_add_static_to_ModManager branch June 21, 2023 07:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Qubus0 Qubus0 Qubus0 approved these changes

@ithinkandicode ithinkandicode Awaiting requested review from ithinkandicode

@otDan otDan Awaiting requested review from otDan

Assignees

@KANAjetzt KANAjetzt

Labels
breaking Breaking change bug Something isn't working
Projects
None yet
Milestone
v6.0.1
Development

Successfully merging this pull request may close these issues.
2 participants
@KANAjetzt @Qubus0