-
Notifications
You must be signed in to change notification settings - Fork 37
Config JSON #31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Config JSON #31
Conversation
This section is not important, and could get out of date quickly
This isn't used atm, but will save mod creators from having to update their manifest.json files when we close GodotModding#13
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After going through all of it, it seems like everything is correctly in place and is well commented, as this is a big pr, I will probably wait for KANA to go through all of it too before approving.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good stuff
Note: I've tested this extensively, incl. with the CLI args, so there shouldn't be any issues or errors unless I've completely missed something
Config JSONs
res://configs
. View the README for full details.get_mod_config(mod_id, key)
.config_defaults
.get_mod_config
when no custom JSON file is present will return your manifest's defaults instead.--configs-path
.Misc Changes
mod_log
anddev_log
methodsnamespace
(AuthorName
)compatible_modloader_version
.Breaking Changes
namespace
extra.godot.config_defaults
extra.godot.compatible_modloader_version