feat: Implement a cache of script inheritence #314
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a clobbered importance order that is no longer being called cosmetically the Inheritance stacks are now being saved so they don't have to be recalced again on each iteration, this saves the majority of the sorting time
otDan
changed the title
KANAjetzt
reviewed
Jul 1, 2023
Comments describing the sorting process and artifcats
KANAjetzt
reviewed
Jul 1, 2023
KANAjetzt
approved these changes
Jul 1, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a clobbered importance order that is no longer being called cosmetically
the Inheritance stacks are now being saved so they don't have to be recalced again on each iteration, this saves the majority of the sorting time
A ScriptExtensionData type has been removed since it was only used to keep attributes together through the sort and a bit of unnecessary work was done to maintain the type.
closes
#311