Skip to content

feat: add dictionary for overrides based on feature tags to options #326

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

Qubus0
Copy link
Collaborator

@Qubus0 Qubus0 commented Jul 7, 2023

adds a dictionary for overrides based on feature tags to options.

I had to modify ModLoaderLog a little to avoid crashes when the store - and the options themselves in the store - are not available yet, which is the case in the options loading method.

needs to be documented on the options page after merge to main

# Overrides for all available feature tags through OS.has_feature()
# Format: Dictionary[String: ModLoaderOptionsProfile] where the string is a tag
# Warning: Some tags can occur at the same time (Windows + editor for example) -
# In a case where multiple apply, the last one in the dict will override all others

https://docs.godotengine.org/en/3.5/tutorials/export/feature_tags.html

closes #296

@Qubus0 Qubus0 added the enhancement New feature or request label Jul 7, 2023
@Qubus0 Qubus0 added this to the v6.2.0 milestone Jul 7, 2023
@Qubus0 Qubus0 requested review from KANAjetzt and a team July 7, 2023 23:06
@KANAjetzt KANAjetzt changed the title Production and Development Environment Options #296 feat: add dictionary for overrides based on feature tags to options Jul 8, 2023
Copy link
Member

@KANAjetzt KANAjetzt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice - Thank You!
Tested it in Editor with windows and editor flag.

@Qubus0 Qubus0 merged commit 8963712 into GodotModding:main Jul 9, 2023
@Qubus0 Qubus0 deleted the production_and_development_environment_options branch July 9, 2023 12:07
@KANAjetzt KANAjetzt modified the milestones: v6.3.0, v6.2.0 Jul 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Production and Development Environment Options
2 participants