Skip to content

feat: log name wildcards #331

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 17, 2023

Conversation

Qubus0
Copy link
Collaborator

@Qubus0 Qubus0 commented Jul 17, 2023

Before, it was only possible to match 100% of a log name to ignore it e.g. ModLoader:Deprecated. This can get tedious if you want to ignore all logs from a log name.
Now you can use a wildcard at the end e.g. ModLoader:* to ignore all log names starting with that segment.

@Qubus0 Qubus0 added the enhancement New feature or request label Jul 17, 2023
@Qubus0 Qubus0 requested a review from KANAjetzt July 17, 2023 13:43
Copy link
Member

@KANAjetzt KANAjetzt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ty 👍

@Qubus0 Qubus0 added this pull request to the merge queue Jul 17, 2023
Merged via the queue into GodotModding:development with commit 999ec05 Jul 17, 2023
@Qubus0 Qubus0 deleted the feat_log_name_wildcards branch July 17, 2023 14:09
KANAjetzt added a commit that referenced this pull request Nov 28, 2023
@KANAjetzt KANAjetzt added this to the v6.3.0 milestone Nov 28, 2023
@Qubus0 Qubus0 restored the feat_log_name_wildcards branch November 30, 2023 13:53
@Qubus0 Qubus0 mentioned this pull request Nov 30, 2023
@Qubus0 Qubus0 deleted the feat_log_name_wildcards branch December 2, 2023 21:52
GDami added a commit to GDami/godot-mod-loader that referenced this pull request Dec 4, 2023
GDami pushed a commit to GDami/godot-mod-loader that referenced this pull request Dec 4, 2023
* feat: log name wildcards

* refactor: use trim_suffix instead of replace

* fix: bad rename

Revert "feat: log name wildcards (GodotModding#331)"

This reverts commit 999ec05.
GDami pushed a commit to GDami/godot-mod-loader that referenced this pull request Dec 4, 2023
* feat: log name wildcards

* refactor: use trim_suffix instead of replace

* fix: bad rename
GDami pushed a commit to GDami/godot-mod-loader that referenced this pull request Dec 4, 2023
* feat: log name wildcards

* refactor: use trim_suffix instead of replace

* fix: bad rename
GDami pushed a commit to GDami/godot-mod-loader that referenced this pull request Dec 4, 2023
* feat: log name wildcards

* refactor: use trim_suffix instead of replace

* fix: bad rename
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants