-
Notifications
You must be signed in to change notification settings - Fork 37
feat: log name wildcards #331
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Qubus0
merged 3 commits into
GodotModding:development
from
Qubus0:feat_log_name_wildcards
Jul 17, 2023
Merged
feat: log name wildcards #331
Qubus0
merged 3 commits into
GodotModding:development
from
Qubus0:feat_log_name_wildcards
Jul 17, 2023
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KANAjetzt
reviewed
Jul 17, 2023
KANAjetzt
approved these changes
Jul 17, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ty 👍
KANAjetzt
added a commit
that referenced
this pull request
Nov 28, 2023
This reverts commit 999ec05.
GDami
added a commit
to GDami/godot-mod-loader
that referenced
this pull request
Dec 4, 2023
This reverts commit 999ec05.
GDami
pushed a commit
to GDami/godot-mod-loader
that referenced
this pull request
Dec 4, 2023
* feat: log name wildcards * refactor: use trim_suffix instead of replace * fix: bad rename Revert "feat: log name wildcards (GodotModding#331)" This reverts commit 999ec05.
GDami
pushed a commit
to GDami/godot-mod-loader
that referenced
this pull request
Dec 4, 2023
* feat: log name wildcards * refactor: use trim_suffix instead of replace * fix: bad rename
GDami
pushed a commit
to GDami/godot-mod-loader
that referenced
this pull request
Dec 4, 2023
* feat: log name wildcards * refactor: use trim_suffix instead of replace * fix: bad rename
GDami
pushed a commit
to GDami/godot-mod-loader
that referenced
this pull request
Dec 4, 2023
* feat: log name wildcards * refactor: use trim_suffix instead of replace * fix: bad rename
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before, it was only possible to match 100% of a log name to ignore it e.g.
ModLoader:Deprecated
. This can get tedious if you want to ignore all logs from a log name.Now you can use a wildcard at the end e.g.
ModLoader:*
to ignore all log names starting with that segment.