Skip to content

feat: script extensions sorter checks load order #382

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Apr 9, 2024
Merged

feat: script extensions sorter checks load order #382

merged 4 commits into from
Apr 9, 2024

Conversation

KANAjetzt
Copy link
Member

Cherry-picked #357

Original description:

the script extensions sorter will check load order to sort extensions of the same vanilla script

inheritance is still the first way of sorting, this only sorts conflicting extensions of the same vanilla script

@KANAjetzt
feat: script extensions sorter checks load order (GodotModding#357)
430565f 
* added a comparator method to sort extensions of the same script

added a comparator method to sort extensions of the same script following the load order

* added a table to avoid iterating through the load order every comparison

* style edits/spacing changes

renamed a var, added spacing to keep the style consistency

* style: added an empty line

* changed get_string_in_between to get_mod_dir

* better description for get_mod_dir
@KANAjetzt KANAjetzt added enhancement New feature or request 4.x labels Apr 4, 2024
@KANAjetzt KANAjetzt added this to the 4.x - 7.0.0 milestone Apr 4, 2024
@KANAjetzt KANAjetzt requested review from Qubus0, otDan and a team April 4, 2024 06:50
@KANAjetzt KANAjetzt self-assigned this Apr 4, 2024
@KANAjetzt KANAjetzt changed the title feat: script extensions sorter checks load order (#357) feat: script extensions sorter checks load order Apr 4, 2024
@KANAjetzt KANAjetzt mentioned this pull request Apr 4, 2024
Merged
Qubus0
Qubus0 reviewed Apr 5, 2024
View reviewed changes
Qubus0
Qubus0 reviewed Apr 5, 2024
View reviewed changes
Copy link
Collaborator

@Qubus0 Qubus0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

right. this one fixes one issue where script extensions were loaded based on filename even if the mod dependencies said otherwise 👍

@KANAjetzt KANAjetzt mentioned this pull request Apr 9, 2024
Closed
@KANAjetzt KANAjetzt requested a review from Qubus0 April 9, 2024 20:25
@KANAjetzt KANAjetzt added this pull request to the merge queue Apr 9, 2024
Merged via the queue into GodotModding:4.x with commit 7a9deb5 Apr 9, 2024
@KANAjetzt KANAjetzt deleted the feat_script_extensions_sorter_checks_load_order branch April 9, 2024 20:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Qubus0 Qubus0 Qubus0 approved these changes

@otDan otDan Awaiting requested review from otDan

Assignees

@KANAjetzt KANAjetzt

Labels
4.x enhancement New feature or request
Projects
None yet
Milestone
4.x - 7.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@KANAjetzt @Qubus0