Skip to content

Add required tag: compatible_modloader_version #40

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 16, 2023
Merged

Add required tag: compatible_modloader_version #40

merged 2 commits into from
Jan 16, 2023

Conversation

ithinkandicode
Copy link
Collaborator

Add required tag: "compatible_modloader_version"

@ithinkandicode ithinkandicode changed the title Add required tag: "compatible_modloader_version" Add required tag: compatible_modloader_version Jan 16, 2023
Qubus0
Qubus0 reviewed Jan 16, 2023
View reviewed changes
Copy link
Collaborator

@Qubus0 Qubus0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we use mod_loader or modloader? Hard to argue about grammar with snake case, but I don't think it would be one word

@ithinkandicode
Copy link
Collaborator Author

Do we use mod_loader or modloader?

Agreed, thank you, fixed!

@ithinkandicode ithinkandicode merged commit 1c53835 into GodotModding:main Jan 16, 2023
@ithinkandicode ithinkandicode mentioned this pull request Jan 16, 2023
Closed
3 tasks
@ithinkandicode ithinkandicode deleted the add-required-tag-compatible_modloader_version branch January 17, 2023 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Qubus0 Qubus0 Qubus0 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ithinkandicode @Qubus0