fix: broken TranslationServer when added translation fails to load #414
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KANAjetzt
changed the title
KANAjetzt
pushed a commit
to KANAjetzt/godot-mod-loader
that referenced
this pull request
Jan 25, 2025
…odotModding#414) fixed broken TranslationServer when added translation fails to load
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jan 26, 2025
#520) fix: broken TranslationServer when added translation fails to load (#414) fixed broken TranslationServer when added translation fails to load Co-authored-by: Luca Martinelli <[email protected]>
KANAjetzt
added a commit
that referenced
this pull request
Jan 26, 2025
#520) fix: broken TranslationServer when added translation fails to load (#414) fixed broken TranslationServer when added translation fails to load Co-authored-by: Luca Martinelli <[email protected]>
ZackeryRSmith
added
bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a null check to ensure broken translation files don't break the game's localization.
Godots translation.cpp has no safety checks when calling TranslationServer::add_translation. (as of 4.2.2)
If for any reason a null-object is passed to it it will cause the translation server to break for the entire session.