Skip to content

fix: 🐛 Take resource remapping into account #482

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 5, 2024
Merged

fix: 🐛 Take resource remapping into account #482

merged 1 commit into from
Dec 5, 2024

Conversation

KANAjetzt
Copy link
Member

added ResourceLoader.exists() to _ModLoaderFile.file_exists()

closes #481

@KANAjetzt
fix: 🐛 Take resource remapping into account
deb8c81 
added `ResourceLoader.exists()` to `_ModLoaderFile.file_exists()`

closes GodotModding#481
@KANAjetzt KANAjetzt added bug Something isn't working 4.x labels Dec 5, 2024
@KANAjetzt KANAjetzt added this to the 4.x - 7.0.0 milestone Dec 5, 2024
@KANAjetzt KANAjetzt requested a review from Qubus0 December 5, 2024 20:35
@KANAjetzt KANAjetzt self-assigned this Dec 5, 2024
Qubus0
Qubus0 approved these changes Dec 5, 2024
View reviewed changes
Copy link
Collaborator

@Qubus0 Qubus0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yep that also works. one method to rule them all instead of always thinking about if it's a resource or not

@KANAjetzt KANAjetzt added this pull request to the merge queue Dec 5, 2024
Merged via the queue into GodotModding:4.x with commit b18acd9 Dec 5, 2024
2 checks passed
@KANAjetzt KANAjetzt deleted the fix_use_ResourceLoader_exists branch December 5, 2024 20:41
This was referenced Dec 7, 2024
Closed
Closed
KANAjetzt added a commit to KANAjetzt/godot-mod-loader that referenced this pull request Jan 25, 2025
@KANAjetzt
fix: 🐛 Take resource remapping into account (GodotModding#482)
01d27f0 
added `ResourceLoader.exists()` to `_ModLoaderFile.file_exists()`

closes GodotModding#481
@KANAjetzt KANAjetzt mentioned this pull request Jan 25, 2025
Merged
github-merge-queue bot pushed a commit that referenced this pull request Jan 26, 2025
@KANAjetzt
fix: 🐛 Take resource remapping into account (#524)
24e7295 
fix: 🐛 Take resource remapping into account (#482)

added `ResourceLoader.exists()` to `_ModLoaderFile.file_exists()`

closes #481
KANAjetzt added a commit that referenced this pull request Jan 26, 2025
@KANAjetzt
fix: 🐛 Take resource remapping into account (#524)
c74152b 
fix: 🐛 Take resource remapping into account (#482)

added `ResourceLoader.exists()` to `_ModLoaderFile.file_exists()`

closes #481
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Qubus0 Qubus0 Qubus0 approved these changes

Assignees

@KANAjetzt KANAjetzt

Labels
4.x bug Something isn't working
Projects
None yet
Milestone
4.x - 7.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@KANAjetzt @Qubus0