Skip to content

--only-setup cli arg #94

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 5, 2023
Merged

--only-setup cli arg #94

merged 1 commit into from
Feb 5, 2023

Conversation

KANAjetzt
Copy link
Member

@KANAjetzt KANAjetzt commented Feb 4, 2023

Needs to be merged after #89

Adds cmd arg:

  • --only-setup
    Allows to setup the mod loader without user notification, or auto restart ( upcoming PR ).

Request from Mythic ( Thunderstore ):

Mythic — 30/01/2023 09:39
how about would it be possible to support running just the installation step without restarting, but rather shutting down once it's complete?
that way we can use that as the "installer" on the manager, and you don't need to worry about CLI arg handling in the restart phase

Mythic — 30/01/2023 09:43
and if that can return an appropriate exit code, (0 for success, non-zero for fail), that'd be great too
then we can have the manager just run that for install

@KANAjetzt KANAjetzt added enhancement New feature or request installation labels Feb 4, 2023
@KANAjetzt KANAjetzt requested review from Qubus0 and a team February 4, 2023 09:54
@KANAjetzt KANAjetzt changed the title ✔ added --only-setup cli arg --only-setup cli arg Feb 4, 2023
@Qubus0
Copy link
Collaborator

Qubus0 commented Feb 5, 2023

#95 is merged, there should be no more unexpected override.cfg

@KANAjetzt KANAjetzt merged commit cad3397 into GodotModding:develop Feb 5, 2023
@KANAjetzt KANAjetzt deleted the only_setup_cmd_arg branch February 8, 2023 18:32
@KANAjetzt KANAjetzt mentioned this pull request Feb 15, 2023
@KANAjetzt KANAjetzt mentioned this pull request Feb 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request installation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants