--setup-create-override-cfg cli arg #99
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
otDan
approved these changes
Feb 6, 2023
Qubus0
reviewed
Feb 6, 2023
| @@ -58,7 +59,11 @@ func try_setup_modloader() -> void: | |||
| if is_loader_set_up() and not is_loader_setup_applied(): | |||
| modloaderutils.log_info("ModLoader is set up, but the game needs to be restarted", LOG_NAME) | |||
| ProjectSettings.set_setting(settings.IS_LOADER_SETUP_APPLIED, true) | |||
| var _savecustom_error: int = ProjectSettings.save_custom(modloaderutils.get_override_path()) | |||
|
|
|||
| if is_setup_create_override_cfg: | |||
There was a problem hiding this comment.
why is this here and not only in setup_modloader? shouldn't everything be set up already?
There was a problem hiding this comment.
ProjectSettings.set_setting(settings.IS_LOADER_SETUP_APPLIED, true)
Only to save this setting.
This will be fixed in one of the next PRs by using the method of #96
store log backups and rotate them like godot
|
We can leave this open until I fixed the double pck patching. |
Previously this func would not log to the file, which means it wouldn't show in the godot.log during mod development. Note: Unlike the `"error"` condition, I've only used `push_error` instead of also using `printerr`, because `push_error` also seems to print the error already (incl. the `ERROR: ` prefix, which `printerr` doesn't include)
Reduce manifest.json debug log length
…elog `log_fatal` - add the missing log to file
…m/KANAjetzt/godot-mod-loader into setup_create_override_cfg_cli_arg
Merged
Merged
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds cmd arg:
--setup-create-override-cfg
Forces the setup to create the
override.cfgin the game base directory.Skips the
project.binaryinjection.The project binary injection is skipped in that case.