Skip to content

Commit c5d7c11

Browse files
author
Simon Zeltser
authored
Change to endpoints managed rollout (#1054)
* [DO NOT MERGE] Change to endpoints managed rollout * Fixing lint issues\ * fixing copyright in endpoints * fix copyright on endpoints * CR comments
1 parent f87b52b commit c5d7c11

File tree

6 files changed

+10
-11
lines changed

6 files changed

+10
-11
lines changed

endpoints/getting-started-grpc/README.md

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -71,7 +71,6 @@ and [SDK](https://cloud.google.com/sdk/) configured.
7171
```bash
7272
GCLOUD_PROJECT=$(curl -s "http://metadata.google.internal/computeMetadata/v1/project/project-id" -H "Metadata-Flavor: Google")
7373
SERVICE_NAME=hellogrpc.endpoints.${GCLOUD_PROJECT}.cloud.goog
74-
SERVICE_CONFIG_ID=<Your Config ID>
7574
```
7675
7776
1. Pull your credentials to access Container Registry, and run your gRPC server container
@@ -91,7 +90,7 @@ and [SDK](https://cloud.google.com/sdk/) configured.
9190
--link=grpc-hello:grpc-hello \
9291
gcr.io/endpoints-release/endpoints-runtime:1 \
9392
--service=${SERVICE_NAME} \
94-
--version=${SERVICE_CONFIG_ID} \
93+
--rollout_strategy=managed \
9594
--http2_port=9000 \
9695
--backend=grpc://grpc-hello:50051
9796
```
@@ -116,7 +115,7 @@ and [SDK](https://cloud.google.com/sdk/) configured.
116115
gcloud container clusters create my-cluster
117116
```
118117
119-
1. Edit `deployment.yaml`. Replace `SERVICE_NAME`, `SERVICE_CONFIG_ID`, and `GCLOUD_PROJECT` with your values.
118+
1. Edit `deployment.yaml`. Replace `SERVICE_NAME` and `GCLOUD_PROJECT` with your values.
120119
121120
1. Deploy to GKE
122121

endpoints/getting-started-grpc/deployment.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,7 @@ spec:
4444
"--http2_port=9000",
4545
"--backend=grpc://127.0.0.1:50051",
4646
"--service=SERVICE_NAME",
47-
"--version=SERVICE_CONFIG_ID",
47+
"--rollout_strategy=managed",
4848
]
4949
ports:
5050
- containerPort: 9000

endpoints/getting-started/deployment.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,7 @@ spec:
4545
"--http_port=8081",
4646
"--backend=127.0.0.1:8080",
4747
"--service=SERVICE_NAME",
48-
"--version=SERVICE_CONFIG_ID",
48+
"--rollout_strategy=managed",
4949
]
5050
# [END esp]
5151
ports:

endpoints/getting-started/src/main/appengine/app.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,5 +24,5 @@ endpoints_api_service:
2424
# The following values are to be replaced by information from the output of
2525
# 'gcloud endpoints services deploy openapi-appengine.yaml' command.
2626
name: ENDPOINTS-SERVICE-NAME
27-
config_id: ENDPOINTS-CONFIG-ID
27+
rollout_strategy: managed
2828
# [END configuration]

endpoints/getting-started/src/main/java/com/example/endpoints/AuthInfoServlet.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
/*
2-
* Copyright 2015 Google Inc.
3-
*
2+
* Copyright 2017 Google Inc.
3+
*
44
* Licensed under the Apache License, Version 2.0 (the "License");
55
* you may not use this file except in compliance with the License.
66
* You may obtain a copy of the License at
@@ -12,7 +12,7 @@
1212
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
1313
* See the License for the specific language governing permissions and
1414
* limitations under the License.
15-
*/
15+
*/
1616

1717

1818
package com.example.endpoints;

endpoints/multiple-versions/src/main/appengine/app.yaml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ handlers:
2121
secure: always
2222

2323
endpoints_api_service:
24-
# The following values are to be replaced by information from the output of
24+
# The following value is to be replaced by information from the output of
2525
# 'gcloud endpoints services deploy openapi-v1.yaml openapi-v2.yaml' command.
2626
name: ENDPOINTS-SERVICE-NAME
27-
config_id: ENDPOINTS-CONFIG-ID
27+
rollout_strategy: managed

0 commit comments

Comments
 (0)