Skip to content

Change to endpoints managed rollout #1054

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

simonz130
Copy link

We introduce a new feature where we can specify in YAML that service configuration for Endpoints is going to be managed. This means that the service will pull latest deployed service configuration automatically, rather than requiring customer to specify specific version of service configuration.

New flag:
--rollout_strategy=managed
Previously the only way to specify a version was using the following flag:
--version=SERVICE_CONFIG_ID

@simonz130 simonz130 added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Mar 8, 2018
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Mar 8, 2018
@lesv
Copy link
Contributor

lesv commented Mar 8, 2018

[ERROR] src/main/java/com/example/endpoints/AuthInfoServlet.java:[1] (header) RegexpHeader: Line does not match expected header line of '^\W+\*?\W*Copyright 20\d\d Google Inc.$'.
[ERROR] src/main/java/com/example/endpoints/EchoServlet.java:[1] (header) RegexpHeader: Line does not match expected header line of '^\W+\*?\W*Copyright 20\d\d Google Inc.$'.
[ERROR] Failed to execute goal org.apache.maven.plugins:maven-checkstyle-plugin:2.17:check (default) on project endpoints: You have 2 Checkstyle violations. -> [Help 1]
[ERROR] 
[ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
[ERROR] Re-run Maven using the -X switch to enable full debug logging.
[ERROR] 
[ERROR] For more information about the errors and possible solutions, please read the following articles:
[ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoFailureException


[ID: 4004795] Build finished after 109 secs, exit value: 1

Copy link
Contributor

@lesv lesv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - but it appears you need to fix a few things, so ping once that's done. Try doing a mvn clean verify before submitting. (It runs the style checker)

@simonz130 simonz130 removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Mar 28, 2018
@simonz130 simonz130 changed the title [DO NOT MERGE] Change to endpoints managed rollout Change to endpoints managed rollout Mar 28, 2018
Copy link
Contributor

@wmwong wmwong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The app.yaml files in getting-started/ and multiple-versions/ need to be updated as well (remove config id, add rollout_strategy managed).

@@ -116,7 +115,7 @@ and [SDK](https://cloud.google.com/sdk/) configured.
gcloud container clusters create my-cluster
```

1. Edit `deployment.yaml`. Replace `SERVICE_NAME`, `SERVICE_CONFIG_ID`, and `GCLOUD_PROJECT` with your values.
1. Edit `deployment.yaml`. Replace `SERVICE_NAME` and `GCLOUD_PROJECT` with your values.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd prefer to see GOOGLE_CLOUD_PROJECT, but I won't block on it.

lesv
lesv previously approved these changes Apr 4, 2018
Copy link
Contributor

@navinger navinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@simonz130 simonz130 merged commit c5d7c11 into GoogleCloudPlatform:master Apr 4, 2018
@simonz130 simonz130 deleted the introduce_managedrollout branch April 4, 2018 02:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants