-
Notifications
You must be signed in to change notification settings - Fork 2.9k
Change to endpoints managed rollout #1054
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change to endpoints managed rollout #1054
Conversation
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - but it appears you need to fix a few things, so ping once that's done. Try doing a mvn clean verify
before submitting. (It runs the style checker)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The app.yaml files in getting-started/ and multiple-versions/ need to be updated as well (remove config id, add rollout_strategy managed).
@@ -116,7 +115,7 @@ and [SDK](https://cloud.google.com/sdk/) configured. | |||
gcloud container clusters create my-cluster | |||
``` | |||
|
|||
1. Edit `deployment.yaml`. Replace `SERVICE_NAME`, `SERVICE_CONFIG_ID`, and `GCLOUD_PROJECT` with your values. | |||
1. Edit `deployment.yaml`. Replace `SERVICE_NAME` and `GCLOUD_PROJECT` with your values. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd prefer to see GOOGLE_CLOUD_PROJECT, but I won't block on it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
We introduce a new feature where we can specify in YAML that service configuration for Endpoints is going to be managed. This means that the service will pull latest deployed service configuration automatically, rather than requiring customer to specify specific version of service configuration.
New flag:
--rollout_strategy=managed
Previously the only way to specify a version was using the following flag:
--version=SERVICE_CONFIG_ID